Re: [PATCH v2] i2c: aspeed: disable additional device addresses on ast2[56]xx

From: Brendan Higgins
Date: Fri May 07 2021 - 15:57:36 EST


On Thu, May 6, 2021 at 1:54 PM Zev Weiss <zev@xxxxxxxxxxxxxxxxx> wrote:
>
> The ast25xx and ast26xx have, respectively, two and three configurable
> slave device addresses to the ast24xx's one. We only support using
> one at a time, but the others may come up in an indeterminate state
> depending on hardware/bootloader behavior, so we need to make sure we
> disable them so as to avoid ending up with phantom devices on the bus.
>
> Signed-off-by: Zev Weiss <zev@xxxxxxxxxxxxxxxxx>

Looks great! No concerns from me.

Nevertheless, I am not in a position to test this at this time. Joel,
or Andrew could one of you (or someone else on the mailing list) test
this?

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>