RE: [PATCH v3 0/3] fsdax: Factor helper functions to simplify the code

[ruansy.fnst@xxxxxxxxxxx]

Hi, Dan

Do you have any comments on this?


--
Thanks,
Ruan Shiyang.

> -----Original Message-----
> From: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
> Sent: Thursday, April 22, 2021 9:45 PM
> Subject: [PATCH v3 0/3] fsdax: Factor helper functions to simplify the code
> 
> From: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxxxxx>
> 
> The page fault part of fsdax code is little complex. In order to add CoW feature
> and make it easy to understand, I was suggested to factor some helper functions
> to simplify the current dax code.
> 
> This is separated from the previous patchset called "V3 fsdax,xfs: Add
> reflink&dedupe support for fsdax", and the previous comments are here[1].
> 
> [1]:
> https://patchwork.kernel.org/project/linux-nvdimm/patch/20210319015237.99
> 3880-3-ruansy.fnst@xxxxxxxxxxx/
> 
> Changes from V2:
>  - fix the type of 'major' in patch 2
>  - Rebased on v5.12-rc8
> 
> Changes from V1:
>  - fix Ritesh's email address
>  - simplify return logic in dax_fault_cow_page()
> 
> (Rebased on v5.12-rc8)
> ==
> 
> Shiyang Ruan (3):
>   fsdax: Factor helpers to simplify dax fault code
>   fsdax: Factor helper: dax_fault_actor()
>   fsdax: Output address in dax_iomap_pfn() and rename it
> 
>  fs/dax.c | 443 +++++++++++++++++++++++++++++--------------------------
>  1 file changed, 234 insertions(+), 209 deletions(-)
> 
> --
> 2.31.1