Re: [PATCH 1/1] drm/msm/dpu: Fix error return code in dpu_mdss_init()

[Leizhen (ThunderTown)]

On 2021/5/8 14:09, Stephen Boyd wrote:
> Quoting Zhen Lei (2021-05-07 19:42:54)
>> Fix to return a negative error code from the error handling case instead
>> of 0, as done elsewhere in this function.
>>
>> Fixes: 070e64dc1bbc ("drm/msm/dpu: Convert to a chained irq chip")
>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>> ---
>>  drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
>> index 06b56fec04e0..1b6c9fb500a1 100644
>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_mdss.c
>> @@ -253,8 +253,10 @@ int dpu_mdss_init(struct drm_device *dev)
>>                 goto irq_domain_error;
>>
>>         irq = platform_get_irq(pdev, 0);
>> -       if (irq < 0)
>> +       if (irq < 0) {
>> +               ret = irq;
>>                 goto irq_error;
>> +       }
> 
> It would be even better if ret wasn't assigned to 0 at the start of this
> function.

The returned error code is not unique.

> 
>>
>>         irq_set_chained_handler_and_data(irq, dpu_mdss_irq,
>>                                          dpu_mdss);
> 
> .
>