[PATCH] ocfs2: Reomve err less than zero check
From: Jiapeng Chong
Date: Sat May 08 2021 - 06:41:34 EST
The check for err < 0 is always false because err is an enum and can
never be less than zero.
Clean up the following coccicheck warning:
fs/ocfs2/dlm/dlmdebug.c:222 dlm_errname() warn: unsigned 'err' is never
less than zero.
fs/ocfs2/dlm/dlmdebug.c:214 dlm_errmsg() warn: unsigned 'err' is never
less than zero.
Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---
fs/ocfs2/dlm/dlmdebug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
index d442cf5..817914d 100644
--- a/fs/ocfs2/dlm/dlmdebug.c
+++ b/fs/ocfs2/dlm/dlmdebug.c
@@ -211,7 +211,7 @@ void dlm_print_one_lock(struct dlm_lock *lockid)
const char *dlm_errmsg(enum dlm_status err)
{
- if (err >= DLM_MAXSTATS || err < 0)
+ if (err >= DLM_MAXSTATS)
return dlm_errmsgs[DLM_MAXSTATS];
return dlm_errmsgs[err];
}
@@ -219,7 +219,7 @@ const char *dlm_errmsg(enum dlm_status err)
const char *dlm_errname(enum dlm_status err)
{
- if (err >= DLM_MAXSTATS || err < 0)
+ if (err >= DLM_MAXSTATS)
return dlm_errnames[DLM_MAXSTATS];
return dlm_errnames[err];
}
--
1.8.3.1