Re: [PATCH] nvmem: sprd: Fix an error message

[Chunyan Zhang]

On Sat, 8 May 2021 at 01:02, Christophe JAILLET
<christophe.jaillet@xxxxxxxxxx> wrote:
>
> 'ret' is known to be 0 here.
> The expected error status is stored in 'status', so use it instead.
>
> Also change %d in %u, because status is an u32, not a int.
>
> Fixes: 096030e7f449 ("nvmem: sprd: Add Spreadtrum SoCs eFuse support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Thanks.
Acked-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>


> ---
>  drivers/nvmem/sprd-efuse.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/sprd-efuse.c b/drivers/nvmem/sprd-efuse.c
> index 5d394559edf2..e3e721d4c205 100644
> --- a/drivers/nvmem/sprd-efuse.c
> +++ b/drivers/nvmem/sprd-efuse.c
> @@ -234,7 +234,7 @@ static int sprd_efuse_raw_prog(struct sprd_efuse *efuse, u32 blk, bool doub,
>         status = readl(efuse->base + SPRD_EFUSE_ERR_FLAG);
>         if (status) {
>                 dev_err(efuse->dev,
> -                       "write error status %d of block %d\n", ret, blk);
> +                       "write error status %u of block %d\n", status, blk);
>
>                 writel(SPRD_EFUSE_ERR_CLR_MASK,
>                        efuse->base + SPRD_EFUSE_ERR_CLR);
> --
> 2.30.2
>