[PATCH] s390/hvc_iucv: Drop unnecessary NULL check after container_of

From: Guenter Roeck
Date: Mon May 10 2021 - 21:25:29 EST


The result of container_of() operations is never NULL unless the extracted
element is the first element of the embedded structure. This is not the
case here. The NULL check is therefore unnecessary and misleading.
Remove it.

This change was made automatically with the following Coccinelle script.

@@
type t;
identifier v;
statement s;
@@

<+...
(
t v = container_of(...);
|
v = container_of(...);
)
...
when != v
- if (\( !v \| v == NULL \) ) s
...+>

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
---
drivers/tty/hvc/hvc_iucv.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/hvc/hvc_iucv.c b/drivers/tty/hvc/hvc_iucv.c
index 2af1e5751bd6..3bd03ae01bf5 100644
--- a/drivers/tty/hvc/hvc_iucv.c
+++ b/drivers/tty/hvc/hvc_iucv.c
@@ -438,8 +438,6 @@ static void hvc_iucv_sndbuf_work(struct work_struct *work)
struct hvc_iucv_private *priv;

priv = container_of(work, struct hvc_iucv_private, sndbuf_work.work);
- if (!priv)
- return;

spin_lock_bh(&priv->lock);
hvc_iucv_send(priv);
--
2.25.1