Re: [f2fs-dev] [PATCH v2] f2fs: support iflag change given the mask

[Chao Yu]

On 2021/5/10 22:42, Jaegeuk Kim wrote:
> In f2fs_fileattr_set(),
>
> 	if (!fa->flags_valid)
> 		mask &= FS_COMMON_FL;
>
> In this case, we can set supported flags by mask only instead of BUG_ON.
>
> /* Flags shared betwen flags/xflags */
> 	(FS_SYNC_FL | FS_IMMUTABLE_FL | FS_APPEND_FL | \
> 	 FS_NODUMP_FL |	FS_NOATIME_FL | FS_DAX_FL | \
> 	 FS_PROJINHERIT_FL)
>
> Fixes: 4c5b47997521 ("vfs: add fileattr ops")
> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

Except fixes line issue pointed out by Eric, other part looks good
to me.

Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx>

Thanks,