Re: [PATCH v1 2/2] memory: tegra: Enable compile testing for all drivers

From: Krzysztof Kozlowski
Date: Tue May 11 2021 - 12:41:45 EST


On 10/05/2021 17:37, Dmitry Osipenko wrote:
> Enable compile testing for all Tegra memory drivers.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> drivers/memory/tegra/Kconfig | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
> index a70967a56e52..a910f661105f 100644
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> @@ -2,7 +2,7 @@
> config TEGRA_MC
> bool "NVIDIA Tegra Memory Controller support"
> default y
> - depends on ARCH_TEGRA
> + depends on (ARCH_TEGRA || COMPILE_TEST)

No need for ().

> select INTERCONNECT
> help
> This driver supports the Memory Controller (MC) hardware found on
> @@ -11,7 +11,7 @@ config TEGRA_MC
> config TEGRA20_EMC
> tristate "NVIDIA Tegra20 External Memory Controller driver"
> default y
> - depends on TEGRA_MC && ARCH_TEGRA_2x_SOC
> + depends on TEGRA_MC && (ARCH_TEGRA_2x_SOC || COMPILE_TEST)

There is a lot of "depends on TEGRA_MC". How about making it a "if
TEGRA_MC" block?

Best regards,
Krzysztof