Re: [PATCH 1/2] dt-bindings: phy: Introduce Qualcomm eDP/DP PHY binding

From: Stephen Boyd
Date: Tue May 11 2021 - 13:24:10 EST


Quoting Bjorn Andersson (2021-05-10 21:19:29)
> diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> new file mode 100644
> index 000000000000..c258e4f7e332
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/phy/qcom,edp-phy.yaml#";
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> +
> +title: Qualcomm DP/eDP PHY
> +
> +maintainers:
> + - Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> +
> +description:
> + The Qualcomm DP/eDP PHY is found in a number of Qualcomm platform and
> + provides the physical interface for DisplayPort and Embedded Display Port.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sc8180x-dp-phy
> + - qcom,sc8180x-edp-phy
> +
> + reg:
> + items:
> + - description: PHY base register block
> + - description: tx0 register block
> + - description: tx1 register block
> + - description: PLL register block
> +
> + clocks:
> + maxItems: 2

Can this be items: - const: again? I think having maxItems means you can
have one or two items, which wouldn't match the number of clock-names
then.

> +
> + clock-names:
> + items:
> + - const: aux
> + - const: cfg_ahb
> +