Re: [PATCH v4 1/2] selftests/sgx: Rename 'eenter' and 'sgx_call_vdso'

[Jarkko Sakkinen]

On Tue, May 11, 2021 at 11:49:18AM -0700, Dave Hansen wrote:
> On 5/7/21 8:56 PM, Jarkko Sakkinen wrote:
> > Rename symbols for better clarity:
> > 
> > * 'eenter' -> 'vdso_sgx_enter_enclave'
> > * 'sgx_call_vdso' -> 'sgx_enter_enclave'
> 
> Another sentence or two here would do wonders:
> 
> 'eenter' might be confused for directly calling ENCLU[EENTER].  It does
> not.  It calls into the VDSO, which actually has the EENTER instruction.
> 
> 'sgx_call_vdso' is *only* used for entering the enclave.  It's not some
> generic SGX call into the VDSO.
> 
> Make the naming reflect that.
> 
> Right?

Agreed.

I'll spin off a yet new version of the series, taking also care
of the log messages that the enclave loader emits (Renette's
feedback). They should be wrapped with TH_LOG() macro I suppose.

/Jarkko