RE: [PATCH 2/3] x86/MCE/AMD: Helper function to check UMC v2
From: Joshi, Mukul
Date: Tue May 11 2021 - 21:41:26 EST
[AMD Official Use Only - Internal Distribution Only]
Hi Boris,
Thanks for the review comments.
I will update the Subject line and send out an updated patch.
In the meantime, here is the link to where the changes in Patch 2 and 3 are being used:
https://lists.freedesktop.org/archives/amd-gfx/2021-May/063423.html
Thanks.
Regards,
Mukul
-----Original Message-----
From: Borislav Petkov <bp@xxxxxxxxx>
Sent: Tuesday, May 11, 2021 1:35 PM
To: Chatradhi, Naveen Krishna <NaveenKrishna.Chatradhi@xxxxxxx>
Cc: linux-edac@xxxxxxxxxxxxxxx; x86@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; mingo@xxxxxxxxxx; mchehab@xxxxxxxxxx; Joshi, Mukul <Mukul.Joshi@xxxxxxx>
Subject: Re: [PATCH 2/3] x86/MCE/AMD: Helper function to check UMC v2
[CAUTION: External Email]
On Tue, May 11, 2021 at 08:55:37PM +0530, Naveen Krishna Chatradhi wrote:
> Subject: Re: [PATCH 2/3] x86/MCE/AMD: Helper function to check UMC v2
The condensed patch description in the subject line should start with a uppercase letter and should be written in imperative tone:
"x86/MCE/AMD: Add a helper function... "
> Signed-off-by: Mukul Joshi <mukul.joshi@xxxxxxx>
> Reviewed-by: John Clements <John.Clements@xxxxxxx>
> Reviewed-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
This is all fine and dandy but it needs your SOB too when you send the patch.
Please read Documentation/process/submitting-patches.rst
sections
Sign your work - the Developer's Certificate of Origin When to use Acked-by:, Cc:, and Co-developed-by:
> +bool is_smca_umc_v2(int bank)
> +{
> + return (smca_get_bank_type(bank) == SMCA_UMC_V2); }
> +EXPORT_SYMBOL_GPL(is_smca_umc_v2);
This addition looks useless when it doesn't have any users.
Also, I'm pretty sceptical this even makes sense to have it exported - I'm guessing this is for mce_amd.c but I can't say without seeing it in use.
The same remarks hold true for your patch 3.
Thx.
--
Regards/Gruss,
Boris.
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&data=04%7C01%7Cmukul.joshi%40amd.com%7C0a7f1e0a3bf04c9ed89408d914a3141c%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637563512928580623%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=z3xbuS8yX4Ea1kG9tWv0tGNQRPZP9N6QcBI2VNjn6W0%3D&reserved=0