Re: [PATCH kernel v2] powerpc/makefile: Do not redefine $(CPP) for preprocessor

[Alexey Kardashevskiy]

On 5/12/21 09:16, Segher Boessenkool wrote:
> On Tue, May 11, 2021 at 11:30:17PM +1000, Alexey Kardashevskiy wrote:
> > > In any case, please mention the reasoning (and the fact that you are
> > > removing these flags!) in the commit message.  Thanks!
> >
> > but i did mention this, the last paragraph... they are duplicated.
>
> Oh!  I completely missed those few lines.  Sorry for that :-(

Well, I probably should have made it a separate patch anyway, I'll 
repost separately.


> To compensate a bit:
>
> > It still puzzles me why we need -C
> > (preserve comments in the preprocessor output) flag here.
>
> It is so that a human can look at the output and read it.  Comments are
> very significant to human readers :-)

I seriously doubt anyone ever read those :) I suspect this is to pull 
all the licenses in one place and do some checking but I did not dig deep.


--
Alexey