Re: [patch 1/2 v2] x86/cpu: Init AP exception handling from cpu_init_secondary()

From: Thomas Gleixner
Date: Wed May 12 2021 - 05:52:54 EST


On Wed, May 12 2021 at 10:49, Peter Zijlstra wrote:
> On Mon, May 10, 2021 at 11:29:25PM +0200, Thomas Gleixner wrote:
>> +#ifdef CONFIG_SMP
>> +void cpu_init_secondary(void)
>> +{
> /*
> * Relies on the BP having set-up the IDT tables, which
> * are loaded on this CPU in the below
> * cpu_init_exception_handling().
> */
>> + cpu_init_exception_handling();
>> + cpu_init();
>> +}
>> +#endif
>
> Or something along those lines? It took me a little to figure out why
> start_secondary() didn't have idt_setup_traps(), hopefully something
> like this will avoid a little future confusion.

I'll add something to that effect.