Re: [PATCH v5 1/3] kunit: make test->lock irq safe

From: Vlastimil Babka
Date: Wed May 12 2021 - 06:30:27 EST


On 5/11/21 5:07 PM, glittao@xxxxxxxxx wrote:
> From: Vlastimil Babka <vbabka@xxxxxxx>
>
> The upcoming SLUB kunit test will be calling kunit_find_named_resource() from
> a context with disabled interrupts. That means kunit's test->lock needs to be
> IRQ safe to avoid potential deadlocks and lockdep splats.
>
> This patch therefore changes the test->lock usage to spin_lock_irqsave()
> and spin_unlock_irqrestore().
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>
> Signed-off-by: Oliver Glitta <glittao@xxxxxxxxx>

Note v4 had

Reviewed-by: Brendan Higgins <brendanhiggins@xxxxxxxxxx>

and it's unchanged AFAIK.