Re: [PATCH] staging: rtl8723bs: hal: Remove two set but unused variables

From: kernel test robot
Date: Wed May 12 2021 - 06:35:48 EST

Hi "Fabio,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]

url: https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/staging-rtl8723bs-hal-Remove-two-set-but-unused-variables/20210512-162828
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f6d5d118462de2797f5925e04b826f00c66f6325
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1a4e324a51c22525507e749a8826064554e7ad9f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Fabio-M-De-Francesco/staging-rtl8723bs-hal-Remove-two-set-but-unused-variables/20210512-162828
git checkout 1a4e324a51c22525507e749a8826064554e7ad9f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c: In function 'PHY_IQCalibrate_8723B':
>> drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1648:8: warning: variable 'StartTime' set but not used [-Wunused-but-set-variable]
1648 | u32 StartTime;
| ^~~~~~~~~
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c: In function 'PHY_LCCalibrate_8723B':
drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c:1849:8: warning: variable 'StartTime' set but not used [-Wunused-but-set-variable]
1849 | u32 StartTime;
| ^~~~~~~~~


vim +/StartTime +1648 drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c

554c0a3abf216c Hans de Goede 2017-03-29 1612
554c0a3abf216c Hans de Goede 2017-03-29 1613
554c0a3abf216c Hans de Goede 2017-03-29 1614
554c0a3abf216c Hans de Goede 2017-03-29 1615 /* IQK version:V2.5 20140123 */
554c0a3abf216c Hans de Goede 2017-03-29 1616 /* IQK is controlled by Is2ant, RF path */
554c0a3abf216c Hans de Goede 2017-03-29 1617 void PHY_IQCalibrate_8723B(
554c0a3abf216c Hans de Goede 2017-03-29 1618 struct adapter *padapter,
554c0a3abf216c Hans de Goede 2017-03-29 1619 bool bReCovery,
554c0a3abf216c Hans de Goede 2017-03-29 1620 bool bRestore,
554c0a3abf216c Hans de Goede 2017-03-29 1621 bool Is2ant, /* false:1ant, true:2-ant */
554c0a3abf216c Hans de Goede 2017-03-29 1622 u8 RF_Path /* 0:S1, 1:S0 */
554c0a3abf216c Hans de Goede 2017-03-29 1623 )
554c0a3abf216c Hans de Goede 2017-03-29 1624 {
554c0a3abf216c Hans de Goede 2017-03-29 1625 struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
554c0a3abf216c Hans de Goede 2017-03-29 1626
f8010da6556d5c Marco Cesati 2021-03-17 1627 struct dm_odm_t *pDM_Odm = &pHalData->odmpriv;
554c0a3abf216c Hans de Goede 2017-03-29 1628
554c0a3abf216c Hans de Goede 2017-03-29 1629 s32 result[4][8]; /* last is final result */
98ab51df76bf4a Michael Straube 2020-01-10 1630 u8 i, final_candidate;
554c0a3abf216c Hans de Goede 2017-03-29 1631 bool bPathAOK, bPathBOK;
1a4e324a51c225 Fabio M. De Francesco 2021-05-12 1632 s32 RegE94, RegE9C, RegEA4, RegEB4, RegEBC, RegEC4, RegTmp = 0;
554c0a3abf216c Hans de Goede 2017-03-29 1633 bool is12simular, is13simular, is23simular;
554c0a3abf216c Hans de Goede 2017-03-29 1634 bool bSingleTone = false, bCarrierSuppression = false;
554c0a3abf216c Hans de Goede 2017-03-29 1635 u32 IQK_BB_REG_92C[IQK_BB_REG_NUM] = {
554c0a3abf216c Hans de Goede 2017-03-29 1636 rOFDM0_XARxIQImbalance,
554c0a3abf216c Hans de Goede 2017-03-29 1637 rOFDM0_XBRxIQImbalance,
554c0a3abf216c Hans de Goede 2017-03-29 1638 rOFDM0_ECCAThreshold,
554c0a3abf216c Hans de Goede 2017-03-29 1639 rOFDM0_AGCRSSITable,
554c0a3abf216c Hans de Goede 2017-03-29 1640 rOFDM0_XATxIQImbalance,
554c0a3abf216c Hans de Goede 2017-03-29 1641 rOFDM0_XBTxIQImbalance,
554c0a3abf216c Hans de Goede 2017-03-29 1642 rOFDM0_XCTxAFE,
554c0a3abf216c Hans de Goede 2017-03-29 1643 rOFDM0_XDTxAFE,
554c0a3abf216c Hans de Goede 2017-03-29 1644 rOFDM0_RxIQExtAnta
554c0a3abf216c Hans de Goede 2017-03-29 1645 };
554c0a3abf216c Hans de Goede 2017-03-29 1646 /* u32 Path_SEL_BB = 0; */
554c0a3abf216c Hans de Goede 2017-03-29 1647 u32 GNT_BT_default;
554c0a3abf216c Hans de Goede 2017-03-29 @1648 u32 StartTime;
554c0a3abf216c Hans de Goede 2017-03-29 1649
941add8e3e63a4 Puranjay Mohan 2019-05-16 1650 if (!ODM_CheckPowerStatus(padapter))
554c0a3abf216c Hans de Goede 2017-03-29 1651 return;
554c0a3abf216c Hans de Goede 2017-03-29 1652
554c0a3abf216c Hans de Goede 2017-03-29 1653 if (!(pDM_Odm->SupportAbility & ODM_RF_CALIBRATION))
554c0a3abf216c Hans de Goede 2017-03-29 1654 return;
554c0a3abf216c Hans de Goede 2017-03-29 1655
554c0a3abf216c Hans de Goede 2017-03-29 1656 /* 20120213<Kordan> Turn on when continuous Tx to pass lab testing. (required by Edlu) */
554c0a3abf216c Hans de Goede 2017-03-29 1657 if (bSingleTone || bCarrierSuppression)
554c0a3abf216c Hans de Goede 2017-03-29 1658 return;
554c0a3abf216c Hans de Goede 2017-03-29 1659

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip