Re: [PATCH 20/33] locking/atomic: m68k: move to ARCH_ATOMIC

[Greg Ungerer]

Hi Mark, Geert,

On 11/5/21 8:27 pm, Geert Uytterhoeven wrote:
> Hi Mark,
>
> CC Greg
>
> On Tue, May 11, 2021 at 12:00 PM Mark Rutland <mark.rutland@xxxxxxx> wrote:
> > On Tue, May 11, 2021 at 11:27:45AM +0200, Geert Uytterhoeven wrote:
> > > On Mon, May 10, 2021 at 11:42 AM Mark Rutland <mark.rutland@xxxxxxx> wrote:
> > > > We'd like all architectures to convert to ARCH_ATOMIC, as once all
> > > > architectures are converted it will be possible to make significant
> > > > cleanups to the atomics headers, and this will make it much easier to
> > > > generically enable atomic functionality (e.g. debug logic in the
> > > > instrumented wrappers).
> > > >
> > > > As a step towards that, this patch migrates m68k to ARCH_ATOMIC. The
> > > > arch code provides arch_{atomic,atomic64,xchg,cmpxchg}*(), and common
> > > > code wraps these with optional instrumentation to provide the regular
> > > > functions.
> > > >
> > > > Signed-off-by: Mark Rutland <mark.rutland@xxxxxxx>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > > Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > >
> > > I even gave this series a spin on ARAnyM and QEMU, and everything
> > > seems to be fine.
> >
> > Thanks! That's much appreciated; I was able to build-test, but didn't
> > have a suitable setup for boot testing.
> >
> > The Kbuild test robot noticed I broke one configuration by renaming
> > atomic_dec_and_test_lt(), since it's not part of the common atomic API,
> > and is used in get_mmu_context() in <asm/mmu_context.h>.
>
> Ah, that's in the part for Coldfire, so I (and my builds) didn't notice.
>
> > On the primciple of keeping the common atomic API separate from
> > arch-specific bits, I've kept the `arch_` prefix and updated the caller.
> > Does that sound good to you?
>
> That's fine for me, but as this is Coldfire, I'd like to defer to Greg.

Looks fine to me too.

Acked-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>

Regards
Greg