Re: [PATCH 3/6] x86/sev-es: Use __put_user()/__get_user
From: Joerg Roedel
Date: Wed May 12 2021 - 13:13:37 EST
On Wed, May 12, 2021 at 08:57:53AM -0700, Dave Hansen wrote:
> The changelog _helps_, but using a "user" function to handle kernel MMIO
> for its error handling properties seems like it's begging for a comment.
>
> __put_user() also seems to have fun stuff like __chk_user_ptr(). It all
> seems sketchy to me.
Yeah, as Juergen already pointed out, there are certain problems with
that too. But I don't want to write my own accessors, so I will
introduce a separate user and kernel path to these functions.
Regards,
Joerg