[tip: objtool/urgent] objtool: Fix elf_create_undef_symbol() endianness

From: tip-bot2 for Vasily Gorbik
Date: Wed May 12 2021 - 16:02:40 EST


The following commit has been merged into the objtool/urgent branch of tip:

Commit-ID: 7176af27a8bf4ab5b5c7a1850459b194a21cf876
Gitweb: https://git.kernel.org/tip/7176af27a8bf4ab5b5c7a1850459b194a21cf876
Author: Vasily Gorbik <gor@xxxxxxxxxxxxx>
AuthorDate: Wed, 12 May 2021 19:42:10 +02:00
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitterDate: Wed, 12 May 2021 20:25:48 +02:00

objtool: Fix elf_create_undef_symbol() endianness

Currently x86 cross-compilation fails on big endian system with:

x86_64-cross-ld: init/main.o: invalid string offset 488112128 >= 6229 for section `.strtab'

Mark new ELF data in elf_create_undef_symbol() as symbol, so that libelf
does endianness handling correctly.

Fixes: 2f2f7e47f052 ("objtool: Add elf_create_undef_symbol()")
Signed-off-by: Vasily Gorbik <gor@xxxxxxxxxxxxx>
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
Link: https://lore.kernel.org/r/patch-1.thread-6c9df9.git-d39264656387.your-ad-here.call-01620841104-ext-2554@work.hours
---
tools/objtool/elf.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/objtool/elf.c b/tools/objtool/elf.c
index d08f5f3..743c2e9 100644
--- a/tools/objtool/elf.c
+++ b/tools/objtool/elf.c
@@ -762,6 +762,7 @@ struct symbol *elf_create_undef_symbol(struct elf *elf, const char *name)
data->d_buf = &sym->sym;
data->d_size = sizeof(sym->sym);
data->d_align = 1;
+ data->d_type = ELF_T_SYM;

sym->idx = symtab->len / sizeof(sym->sym);