Re: [PATCH] net: mdio: octeon: Fix some double free issues

From: Andrew Lunn
Date: Thu May 13 2021 - 08:22:58 EST


On Thu, May 13, 2021 at 09:24:55AM +0200, Christophe JAILLET wrote:
> 'bus->mii_bus' has been allocated with 'devm_mdiobus_alloc_size()' in the
> probe function. So it must not be freed explicitly or there will be a
> double free.
>
> Remove the incorrect 'mdiobus_free' in the error handling path of the
> probe function and in remove function.
>
> Suggested-By: Andrew Lunn <andrew@xxxxxxx>
> Fixes: 35d2aeac9810 ("phy: mdio-octeon: Use devm_mdiobus_alloc_size()")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

Andrew