Re: [PATCH v2] watchdog: dw_wdt: Fix duplicate included linux/kernel.h

[Guenter Roeck]

On 5/13/21 4:09 AM, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./drivers/watchdog/dw_wdt.c: linux/kernel.h is included more than once.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> Changes in v2:
>    -Adjust header file order, for the follow advice:
>     https://lore.kernel.org/patchwork/patch/1428192/
>
>   drivers/watchdog/dw_wdt.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c
> index 32d0e17..cd57884 100644
> --- a/drivers/watchdog/dw_wdt.c
> +++ b/drivers/watchdog/dw_wdt.c
> @@ -13,22 +13,21 @@
>    */
>   
>   #include <linux/bitops.h>
> -#include <linux/limits.h>
> -#include <linux/kernel.h>
>   #include <linux/clk.h>
> +#include <linux/debugfs.h>
>   #include <linux/delay.h>
>   #include <linux/err.h>
> +#include <linux/interrupt.h>
>   #include <linux/io.h>
>   #include <linux/kernel.h>
> +#include <linux/limits.h>
>   #include <linux/module.h>
>   #include <linux/moduleparam.h>
> -#include <linux/interrupt.h>
>   #include <linux/of.h>
> -#include <linux/pm.h>
>   #include <linux/platform_device.h>
> +#include <linux/pm.h>
>   #include <linux/reset.h>
>   #include <linux/watchdog.h>
> -#include <linux/debugfs.h>
>   
>   #define WDOG_CONTROL_REG_OFFSET		    0x00
>   #define WDOG_CONTROL_REG_WDT_EN_MASK	    0x01