Re: [PATCH] ASoC: qcom: lpass-cpu: Fix pop noise during audio capture begin

[Srinivasa Rao Mandadapu]

Hi Brown,

Thanks for your review comments!!!

On 5/13/2021 7:01 PM, Mark Brown wrote:
> On Thu, May 13, 2021 at 05:15:39PM +0530, Srinivasa Rao Mandadapu wrote:
>
> > +	if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
> > +		ret = regmap_fields_write(i2sctl->spken, id,
> > +						 LPAIF_I2SCTL_SPKEN_ENABLE);
> > +	} else  {
> > +		ret = regmap_fields_write(i2sctl->micen, id,
> > +						 LPAIF_I2SCTL_MICEN_ENABLE);
> > +	}
> This commit doesn't remove the matching update in triger() so we'd have
> two redundant updates.  I guess it's unlikely to be harmful but it looks
> wrong/confusing.

Yes, It's not harmful, as clk_prepare_enable is enabling clock only once 
but maintaining count.

As Some times in Suspend/resume Sequence not hitting startup/shutdown, 
but Trigger, so for maintaining

consistency not removed in trigger.

--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.