Re: [PATCH 5.10 245/530] tty: actually undefine superseded ASYNC flags

[Johan Hovold]

On Fri, May 14, 2021 at 09:55:01AM +0200, Greg Kroah-Hartman wrote:
> On Wed, May 12, 2021 at 05:17:32PM +0200, Johan Hovold wrote:
> > On Wed, May 12, 2021 at 04:45:55PM +0200, Greg Kroah-Hartman wrote:
> > > From: Johan Hovold <johan@xxxxxxxxxx>
> > > 
> > > [ Upstream commit d09845e98a05850a8094ea8fd6dd09a8e6824fff ]
> > > 
> > > Some kernel-internal ASYNC flags have been superseded by tty-port flags
> > > and should no longer be used by kernel drivers.
> > > 
> > > Fix the misspelled "__KERNEL__" compile guards which failed their sole
> > > purpose to break out-of-tree drivers that have not yet been updated.
> > > 
> > > Fixes: 5c0517fefc92 ("tty: core: Undefine ASYNC_* flags superceded by TTY_PORT* flags")
> > > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> > > Link: https://lore.kernel.org/r/20210407095208.31838-2-johan@xxxxxxxxxx
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > 
> > I don't think this should be backported to any stable tree and the
> > stable tag was left out on purpose.
> 
> It's about time that userspace gets this right, so this should be fine
> as it's something that any out-of-tree code is going to have to get
> correct eventually.

Eventually, yes. Just doesn't seem right to break stuff on purpose in a
minor stable update.

That said, I really don't care one bit about out-of-tree drivers so go
ahead if you want to.

Johan