Re: [RESEND PATCH v4 06/10] dt-bindings: gpio: change items restriction of clock for rockchip,gpio-bank

From: Heiko Stuebner
Date: Fri May 14 2021 - 06:07:21 EST


Hi,

Am Donnerstag, 13. Mai 2021, 08:46:06 CEST schrieb cl@xxxxxxxxxxxxxx:
> From: Liang Chen <cl@xxxxxxxxxxxxxx>
>
> The clock property need 2 items on some rockchip chips.
>
> Signed-off-by: Liang Chen <cl@xxxxxxxxxxxxxx>

this patch should definitly move over to Jianquns gpio driver series,
as it introduces the usage of these new clocks.

Also while the single-clock variant definitly doesn't need it,
I think we may want clock-names "apb_pclk", "debounce-ref" for the
2-clock variants?


Heiko

> ---
> Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index d993e00..0d62c28 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -22,7 +22,10 @@ properties:
> maxItems: 1
>
> clocks:
> - maxItems: 1
> + minItems: 1
> + items:
> + - description: APB interface clock source
> + - description: GPIO debounce reference clock source
>
> gpio-controller: true
>
>