Re: [PATCH v7 0/6] w1: ds2438: adding support for calibration of current measurements
From: Greg KH
Date: Fri May 14 2021 - 07:47:23 EST
On Fri, Apr 16, 2021 at 07:17:33PM -0300, Luiz Sampaio wrote:
> The following patches aim to make a user able to calibrate the current
> measurement of the DS2438. This chip uses a offset register in page1, which
> is added to the current register to give the user the current measurement.
> If this value is wrong, the user will get an offset current value, even if
> the current is zero, for instance. This patch gives support for reading the
> page1 registers (including the offset register) and for writing to the
> offset register. The DS2438 datasheet shows a calibration routine, and with
> this patch, the user can do this quickly by writing the correct value to
> the offset register. This patch was tested on real hardware using a power
> supply and an electronic load.
> Please help to review this series of patches.
> Best regards!
> Changes in v7:
> - Build test again
Can you fix the warning in patch 6/6 that the kernel test robot found,