Re: [PATCH v2] samples/kprobes: Fix typo in handler_post()

[Tiezhu Yang]

On 05/14/2021 11:26 PM, Joe Perches wrote:
> On Fri, 2021-05-14 at 16:10 +0800, Tiezhu Yang wrote:
> > It should use post_handler instead of pre_handler in handler_post().
> >
> > Fixes: e16c5dd5157e ("samples/kprobes: Add s390 case in kprobe example module")
> > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > ---
> >
> > v2: rebase on the latest mainline kernel
> >
> >   samples/kprobes/kprobe_example.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
> > index c495664..602db3f 100644
> > --- a/samples/kprobes/kprobe_example.c
> > +++ b/samples/kprobes/kprobe_example.c
> > @@ -89,7 +89,7 @@ static void __kprobes handler_post(struct kprobe *p, struct pt_regs *regs,
> >   		p->symbol_name, p->addr, regs->status);
> >   #endif
> >   #ifdef CONFIG_S390
> > -	pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
> > +	pr_info("<%s> post_handler: p->addr, 0x%p, flags = 0x%lx\n",
> >   		p->symbol_name, p->addr, regs->flags);
> >   #endif
> >   }
> Perhaps better would be to use pr_fmt and remove all the
> embedded pre/post strings.
>
> This would change the style of the output through.
>
> Also fix a defective format in handler_fault ending with
> an 'n' that should be '\n'

Thank you, it looks better, let me send v3 as you suggested.

[...]