Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct powerdown pin for WSA881x

From: Pavel Machek
Date: Sat May 15 2021 - 04:18:26 EST


Hi!

> From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
>
> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ]
>
> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this.
> This was working so far due to a shift bug in gpio driver, however
> once that is fixed this will stop working, so fix this!

I don't see the correspoing update to the driver this talks about.

Do we have corresponding driver in 5.10 and was it fixed to match?

Best regards,
Pavel

> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts
> @@ -1015,7 +1015,7 @@
> left_spkr: wsa8810-left{
> compatible = "sdw10217201000";
> reg = <0 1>;
> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
> #thermal-sensor-cells = <0>;
> sound-name-prefix = "SpkrLeft";
> #sound-dai-cells = <0>;
> @@ -1023,7 +1023,7 @@
>
> right_spkr: wsa8810-right{
> compatible = "sdw10217201000";
> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>;
> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>;
> reg = <0 2>;
> #thermal-sensor-cells = <0>;
> sound-name-prefix = "SpkrRight";

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature