Re: [RFC 13/13] [net-next] 8390: xsurf100: avoid including lib8390.c

From: Finn Thain
Date: Sun May 16 2021 - 00:24:30 EST


On Sun, 16 May 2021, Arnd Bergmann wrote:

> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> This driver always warns about unused functions because it includes
> an file that it doesn't actually need:
>

I don't think you can omit #include "lib8390.c" here without changing
driver behaviour, because of the macros in effect.

I think this change would need some actual testing unless you can show
that the module binary does not change.