Re: [PATCH 1/2] dt-bindings: pci: Add DT bindings for apple,pcie
From: Mark Kettenis
Date: Mon May 17 2021 - 04:18:55 EST
> From: Rob Herring <robh@xxxxxxxxxx>
> Date: Sun, 16 May 2021 21:27:03 -0500
>
> On Sun, 16 May 2021 23:18:46 +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@xxxxxxxxxxx>
> >
> > The Apple PCIe host controller is a PCIe host controller with
> > multiple root ports present in Apple ARM SoC platforms, including
> > various iPhone and iPad devices and the "Apple Silicon" Macs.
> >
> > Signed-off-by: Mark Kettenis <kettenis@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/pci/apple,pcie.yaml | 150 ++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 151 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory
> 20 | #include <dt-bindings/pinctrl/apple.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/pci/apple,pcie.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1416: dt_binding_check] Error 2
While that header file is part of the dependency mentioned in the
cover letter, it isn't even needed. Will fix this when I spin v2.
Sorry for the noise.