Re: [PATCH 1/4] bootconfig: Change array value to use child node
From: Masami Hiramatsu
Date: Mon May 17 2021 - 19:42:22 EST
On Mon, 17 May 2021 11:24:34 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Sun, 16 May 2021 23:55:31 +0900
> Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
> > Change array value to use child node of the xbc_node tree
> > instead of next node.
>
> Hi Masami,
>
> This says what you did, not why you did it. Can you add a comment about
> what the purpose of this change was?
Ah, yes.
Actually, this is an internal (and intermediate) change.
For co-existing a value with subkeys, the barrier is an array of the value,
because both of subkeys and the array elements are using "next" field of
the xbc_node. Thus this changes the array values to use "child" field in
the array case.
Thank you,
>
> Thanks!
>
> -- Steve
>
>
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> > ---
> > tools/bootconfig/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>