Re: [PATCH 051/141] reiserfs: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Mon May 17 2021 - 20:02:31 EST


Hi,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:23, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 11/20/20 12:32, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> ---
>> fs/reiserfs/namei.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/fs/reiserfs/namei.c b/fs/reiserfs/namei.c
>> index 1594687582f0..90bb49bfdba0 100644
>> --- a/fs/reiserfs/namei.c
>> +++ b/fs/reiserfs/namei.c
>> @@ -132,6 +132,7 @@ int search_by_entry_key(struct super_block *sb, const struct cpu_key *key,
>> return IO_ERROR;
>> }
>> PATH_LAST_POSITION(path)--;
>> + break;
>>
>> case ITEM_FOUND:
>> break;
>>