Re: [PATCH 071/141] braille_console: Fix fall-through warnings for Clang

From: Gustavo A. R. Silva
Date: Mon May 17 2021 - 20:38:21 EST


Hi,

I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/20/21 15:16, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 11/20/20 12:34, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
>> ---
>> drivers/accessibility/braille/braille_console.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
>> index 9861302cc7db..359bead4b280 100644
>> --- a/drivers/accessibility/braille/braille_console.c
>> +++ b/drivers/accessibility/braille/braille_console.c
>> @@ -246,6 +246,7 @@ static int keyboard_notifier_call(struct notifier_block *blk,
>> beep(440);
>> }
>> }
>> + break;
>> case KBD_UNBOUND_KEYCODE:
>> case KBD_UNICODE:
>> case KBD_KEYSYM:
>>