Re: [f2fs-dev] [PATCH] f2fs: add MODULE_SOFTDEP to ensure crc32c is included in the initramfs

[Chao Yu]

On 2021/5/18 1:27, Eric Biggers wrote:
> On Mon, May 17, 2021 at 09:15:57AM +0800, Chao Yu wrote:
> > As marcosfrm reported in bugzilla:
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=213089
> >
> > Initramfs generators rely on "pre" softdeps (and "depends") to include
> > additional required modules.
> >
> > F2FS does not declare "pre: crc32" softdep. Then every generator (dracut,
> > mkinitcpio...) has to maintain a hardcoded list for this purpose.
> >
> > Hence let's use MODULE_SOFTDEP("pre: crc32") in f2fs code.
> >
> > Fixes: 43b6573bac95 ("f2fs: use cryptoapi crc32 functions")
> > Reported-by: marcosfrm <marcosfrm@xxxxxxxxx>
> > Signed-off-by: Chao Yu <yuchao0@xxxxxxxxxx>
> > ---
> >   fs/f2fs/super.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 3f8a7a6c250c..fa0ce6301c16 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -4431,4 +4431,5 @@ module_exit(exit_f2fs_fs)
> >   MODULE_AUTHOR("Samsung Electronics's Praesto Team");
> >   MODULE_DESCRIPTION("Flash Friendly File System");
> >   MODULE_LICENSE("GPL");
> > +MODULE_SOFTDEP("pre: crc32c");
>
> Shouldn't it be crc32, not crc32c?

Thanks for the review, will fix.

Thanks,

> - Eric
> .