Re: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang

[Gustavo A. R. Silva]

Hi all,

If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Thanks
--
Gustavo

[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp

On 4/21/21 09:51, Xue, Ying wrote:
> This patch looks good to me.
> 
> -----Original Message-----
> From: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx> 
> Sent: Friday, March 5, 2021 5:25 PM
> To: Jon Maloy <jmaloy@xxxxxxxxxx>; Xue, Ying <Ying.Xue@xxxxxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>; linux-hardening@xxxxxxxxxxxxxxx
> Subject: [PATCH RESEND][next] tipc: Fix fall-through warnings for Clang
> 
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning by explicitly adding a break statement instead of letting the code fall through to the next case.
> 
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> ---
>  net/tipc/link.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/tipc/link.c b/net/tipc/link.c index 115109259430..bcc426e16725 100644
> --- a/net/tipc/link.c
> +++ b/net/tipc/link.c
> @@ -649,6 +649,7 @@ int tipc_link_fsm_evt(struct tipc_link *l, int evt)
>  			break;
>  		case LINK_FAILOVER_BEGIN_EVT:
>  			l->state = LINK_FAILINGOVER;
> +			break;
>  		case LINK_FAILURE_EVT:
>  		case LINK_RESET_EVT:
>  		case LINK_ESTABLISH_EVT:
> --
> 2.27.0
>