Re: [RFC v2 26/32] x86/mm: Move force_dma_unencrypted() to common code

From: Kuppuswamy, Sathyanarayanan
Date: Mon May 17 2021 - 21:28:27 EST




On 5/12/21 8:44 AM, Dave Hansen wrote:
Because the code is already separate. You're actually going to some
trouble to move the SEV-specific code and then combine it with the
TDX-specific code.

Anyway, please just give it a shot. Should take all of ten minutes. If
it doesn't work out in practice, fine. You'll have a good paragraph for
the changelog.

After reviewing the code again, I have noticed that we don't really have
much common code between AMD and TDX. So I don't see any justification for
creating this common layer. So, I have decided to drop this patch and move
Intel TDX specific memory encryption init code to patch titled "[RFC v2 30/32]
x86/tdx: Make DMA pages shared". This model is similar to how AMD-SEV
does the initialization.

I have sent the modified patch as reply to patch titled "[RFC v2 30/32]
x86/tdx: Make DMA pages shared". Please check and let me know your comments.
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer