Re: [PATCH v10 20/33] mm/filemap: Add folio_lock_killable

From: Vlastimil Babka
Date: Tue May 18 2021 - 06:31:59 EST


On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote:
> This is like lock_page_killable() but for use by callers who
> know they have a folio. Convert __lock_page_killable() to be
> __folio_lock_killable(). This saves one call to compound_head() per
> contended call to lock_page_killable().
>
> __folio_lock_killable() is 20 bytes smaller than __lock_page_killable()
> was. lock_page_maybe_drop_mmap() shrinks by 68 bytes and
> __lock_page_or_retry() shrinks by 66 bytes. That's a total of 154 bytes
> of text saved.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>


Acked-by: Vlastimil Babka <vbabka@xxxxxxx>