Re: [PATCH v10 26/33] mm/writeback: Add folio_wait_writeback

From: Vlastimil Babka
Date: Tue May 18 2021 - 07:13:15 EST


On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote:
> wait_on_page_writeback_killable() only has one caller, so convert it to
> call folio_wait_writeback_killable(). For the wait_on_page_writeback()
> callers, add a compatibility wrapper around folio_wait_writeback().
>
> Turning PageWriteback() into folio_writeback() eliminates a call to
> compound_head() which saves 8 bytes and 15 bytes in the two functions.
> That is more than offset by adding the wait_on_page_writeback
> compatibility wrapper for a net increase in text of 15 bytes.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>

Acked-by: Vlastimil Babka <vbabka@xxxxxxx>