Re: [PATCH 3/3] clk: qcom: Add camera clock controller driver for SM8250

From: Robert Foss
Date: Tue May 18 2021 - 08:41:52 EST


> >
> >> +}
> >> +
> >> +static struct platform_driver cam_cc_sm8250_driver = {
> >> + .probe = cam_cc_sm8250_probe,
> >> + .driver = {
> >> + .name = "cam_cc-sm8250",
> >
> > Maybe conforming with the naming scheme of "sdm845-camcc" is the
> > better way to go.
> >
>
> On the other hand there is cam_cc-sc7180. But it doesn't matter either
> way, I will change it.
>

Ah, I only looked at sdm845 for prior art. Either is fine then.

With this fixed & Vinods feedback, feel free to add my r-b.

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>