Re: [PATCH v10 27/33] mm/writeback: Add folio_wait_stable

From: Matthew Wilcox
Date: Tue May 18 2021 - 09:56:52 EST


On Tue, May 18, 2021 at 01:42:04PM +0200, Vlastimil Babka wrote:
> On 5/11/21 11:47 PM, Matthew Wilcox (Oracle) wrote:
> > Move wait_for_stable_page() into the folio compatibility file.
> > folio_wait_stable() avoids a call to compound_head() and is 14 bytes
> > smaller than wait_for_stable_page() was. The net text size grows by 24
> > bytes as a result of this patch.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>
> > Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> > Acked-by: Jeff Layton <jlayton@xxxxxxxxxx>
>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> This seems to remove last user of thp_head(). Remove it as obsolete?

Good catch! I'll squash that in. We're down to just one user of
thp_order in my tree ...