Re: [PATCH 2/5] mm/swap: remove unused local variable nr_shadows

From: Matthew Wilcox
Date: Tue May 18 2021 - 10:38:31 EST


On Tue, May 18, 2021 at 09:53:49PM +0800, Miaohe Lin wrote:
> Since commit 55c653b71e8c ("mm: stop accounting shadow entries"),
> nr_shadows is not used anymore.
>
> Signed-off-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>

Reviewed-by: Matthew Wilcox (Oracle) <willy@xxxxxxxxxxxxx>

> +++ b/mm/swap_state.c
> @@ -114,7 +114,6 @@ int add_to_swap_cache(struct page *page, swp_entry_t entry,
> SetPageSwapCache(page);
>
> do {
> - unsigned long nr_shadows = 0;
>

Perhaps delete the blank line as well?