Re: [PATCH] staging: iio: cdc: ad7746: Fix unnecessary check andassignment in ad7746_probe()
From: Jonathan Cameron
Date: Tue May 18 2021 - 13:58:27 EST
On Tue, 18 May 2021 17:27:07 +0800
tangbin <tangbin@xxxxxxxxxxxxxxxxxxxx> wrote:
> Hi Dan：
> On 2021/5/18 15:52, Dan Carpenter wrote:
> > On Mon, May 17, 2021 at 11:00:06PM +0800, Tang Bin wrote:
> >> @@ -730,11 +730,7 @@ static int ad7746_probe(struct i2c_client *client,
> >> if (ret < 0)
> >> return ret;
> >> - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
> >> - if (ret)
> >> - return ret;
> >> -
> >> - return 0;
> >> + return devm_iio_device_register(indio_dev->dev.parent, indio_dev);
> >> }
> > This sort of thing is done deliberately as a style choice... I probably
> > wouldn't have written it that way myself, but there really isn't a
> > downside to leaving it as-is.
> > The unused "int ret = 0;" just introduces a static checker warning about
> > unused assignments and disables the static checker warning for
> > uninitialized variables so we want to remove that.
> Got it, I will send this patch for you.
I fall a bit different on this and would consider the above a cleanup
though one I'd prefer to get with more significant stuff rather
than on it's own. However, there is already a patch in revision
that includes the same change from Lucas Stankus.
> Tang Bin