Re: [PATCH] nvmet: fix memory leak on nvmet_alloc_ctrl()

From: Wu Bo
Date: Wed May 19 2021 - 00:32:31 EST


On 2021/5/19 4:27, Chaitanya Kulkarni wrote:
On 5/18/21 01:21, Wu Bo wrote:
From: Wu Bo <wubo40@xxxxxxxxxx>

When cntlid_min is greater than cntlid_max,
goto wrong label, should be goto out_free_sqs
label. Otherwise there is a memory leak problem
on the nvmet_alloc_ctrl function().

Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
Fixes: 6d65aeab7bf6e ("nvmet: remove unused ctrl->cqs")
Signed-off-by: Wu Bo <wubo40@xxxxxxxxxx>
---

Looks good, except commit message could be better :-

When cntlid_min is greater than cntlid_max, goto wrong label, should be
goto out_free_sqs label. Otherwise there is a memory leak problem on the
nvmet_alloc_ctrl function().

Fixes: 94a39d61f80f ("nvmet: make ctrl-id configurable")
Fixes: 6d65aeab7bf6 ("nvmet: remove unused ctrl->cqs")
Signed-off-by: Wu Bo <wubo40@xxxxxxxxxx>


with above :-

Thanks for your review. I will make the commit message better.
and I found the nvmet-loop has a similar issue,
will send patch series soon.

Thanks,
Wu Bo

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx>


.