Re: [PATCH 01/17] media: camss: csiphy-3ph: don't print HW version as an error

From: Robert Foss
Date: Wed May 19 2021 - 06:17:00 EST


Hey Jonathan,

Thanks for submitting this series, and including some cleanups and fixes.

On Tue, 11 May 2021 at 20:08, Jonathan Marek <jonathan@xxxxxxxx> wrote:
>
> Avoid unnecessary noise in normal usage (it prints every time CSIPHY is
> powered on).
>
> Signed-off-by: Jonathan Marek <jonathan@xxxxxxxx>
> ---
> drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> index e318c822ab04..5948abdcd220 100644
> --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c
> @@ -163,7 +163,7 @@ static void csiphy_hw_version_read(struct csiphy_device *csiphy,
> hw_version |= readl_relaxed(csiphy->base +
> CSIPHY_3PH_CMN_CSI_COMMON_STATUSn(15)) << 24;
>
> - dev_err(dev, "CSIPHY 3PH HW Version = 0x%08x\n", hw_version);
> + dev_dbg(dev, "CSIPHY 3PH HW Version = 0x%08x\n", hw_version);
> }
>
> /*

Reviewed-by: Robert Foss <robert.foss@xxxxxxxxxx>