Re: [PATCH v2 16/17] leds: leds-nuc: add support for changing the ethernet type indicator

[Mauro Carvalho Chehab]

Em Wed, 19 May 2021 10:02:53 +0200
Marek Behún <kabel@xxxxxxxxxx> escreveu:

> What possible configurations does this support?
> 
> Does this blink on rx/tx activity for a specific ethernet port?
> 

When the indicator is set to monitor Ethernet, it can work on either
LAN1, LAN2 or both LAN interfaces.

> There is a work in progress to add support for transparent offloading of
> LED triggers, with the netdev trigger being the first target.
> 
> This means that after that is done, you could implement this driver so
> that when netdev trigger is enabled on a supported interface, your
> driver will offload the blinking to the HW.

On NUC leds, this is already offloaded to HW/firmware. 

All it takes is to tell the BIOS via ACPI/WMI what LED will be used
for monitoring the Ethernet activity, and on what port(s).
 
> This should probably also work for HDD activity, but this would need a
> blockdev trigger first...

HDD activity is also HW/firmware monitored. The only thing the Kernel
needs to to is to select what LED will be set as the HDD activity
indicator.

Thanks,
Mauro