[PATCH] net: dsa: Remove unsigned expression compared with zero

From: Jiapeng Chong
Date: Wed May 19 2021 - 06:50:21 EST


Variable val is "u32" always >= 0, so val >= 0 condition are redundant.

Clean up the following coccicheck warning:

./drivers/net/dsa/qca8k.c:732:5-8: WARNING: Unsigned expression compared
with zero: val >= 0.

Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx>
---
drivers/net/dsa/qca8k.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/dsa/qca8k.c b/drivers/net/dsa/qca8k.c
index 4753228..7b38b8d 100644
--- a/drivers/net/dsa/qca8k.c
+++ b/drivers/net/dsa/qca8k.c
@@ -729,8 +729,7 @@

mutex_unlock(&bus->mdio_lock);

- if (val >= 0)
- val &= QCA8K_MDIO_MASTER_DATA_MASK;
+ val &= QCA8K_MDIO_MASTER_DATA_MASK;

return val;
}
--
1.8.3.1