Re: [PATCH] soc: samsung: pmu: fix BUT->BIT macro typo
From: Alim Akhtar
Date: Wed May 19 2021 - 10:36:49 EST
Hello Krzysztof
On Mon, May 17, 2021 at 7:59 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxxxxx> wrote:
>
> The macro EXYNOS5_USE_STANDBYWFI_ARM_CORE1 should use BIT, not BUT. Fix
> does not have real effect as the macro is not used in the code.
>
Can we consider removing this? As this is not used in code.
> Fixes: af2e0a0754ac ("ARM: EXYNOS: Add PMU support for exynos5420")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> ---
> include/linux/soc/samsung/exynos-regs-pmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index fc9250fb3133..4bfd9a210da2 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -613,7 +613,7 @@
>
> /* For EXYNOS_CENTRAL_SEQ_OPTION */
> #define EXYNOS5_USE_STANDBYWFI_ARM_CORE0 BIT(16)
> -#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BUT(17)
> +#define EXYNOS5_USE_STANDBYWFI_ARM_CORE1 BIT(17)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE0 BIT(24)
> #define EXYNOS5_USE_STANDBYWFE_ARM_CORE1 BIT(25)
>
> --
> 2.27.0
>
--
Regards,
Alim