Re: [PATCH v4 1/5] dt-bindings: touchscreen: validate nodename

From: Rob Herring
Date: Wed May 19 2021 - 11:29:36 EST


On Wed, 19 May 2021 11:42:17 +0200, Oleksij Rempel wrote:
> Validate touchscreen nodes. Make sure it is named touchscreen*.
>
> Signed-off-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/input/touchscreen/touchscreen.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.example.dt.yaml: edt-ft5x06@38: $nodename:0: 'edt-ft5x06@38' does not match '^touchscreen(@.*)?$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/goodix.example.dt.yaml: gt928@5d: $nodename:0: 'gt928@5d' does not match '^touchscreen(@.*)?$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/touchscreen/goodix.yaml
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/iqs626a.example.dt.yaml: iqs626a@44: $nodename:0: 'iqs626a@44' does not match '^touchscreen(@.*)?$'
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/input/iqs626a.yaml

See https://patchwork.ozlabs.org/patch/1480791

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.