Re: [PATCH 5.10 005/289] KVM: x86/mmu: Remove the defunct update_pte() paging hook

From: Pavel Machek
Date: Wed May 19 2021 - 15:56:57 EST


Hi!

> From: Sean Christopherson <seanjc@xxxxxxxxxx>
>
> commit c5e2184d1544f9e56140791eff1a351bea2e63b9 upstream.
>
> Remove the update_pte() shadow paging logic, which was obsoleted by
> commit 4731d4c7a077 ("KVM: MMU: out of sync shadow core"), but never
> removed. As pointed out by Yu, KVM never write protects leaf page

First, this is cleanup, not a bugfix.

Second, AFAICT 4731d4c7a077 ("KVM: MMU: out of sync shadow core") is
not in 5.10, so this will break stuff according to the changelog.

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: Digital signature