Re: [PATCH v3 0/2] staging: iio: cdc: ad7746: add dt properties for capacitive channel setup

From: Lucas Stankus
Date: Wed May 19 2021 - 17:00:13 EST


On Sun, May 2, 2021 at 2:49 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Sat, 1 May 2021 09:32:03 -0300
> Lucas Stankus <lucas.p.stankus@xxxxxxxxx> wrote:
>
> > This patch series aims to replace the platform_struct for the ad7746 driver
> > in favor of device tree bindings, creating the dt-binding documentation in
> > the process.
> >
> > Since the header file was only used to define the struct and the excitation
> > level values, it was possible to remove the file entirely.
> >
> > Changelog v2 -> v3:
> > - Add application reference note for the inverted EXCX dt bindings
> > - Replace macro with lookup table for setting the capacitive channel
> > excitation voltage
> >
> > Lucas Stankus (2):
> > dt-bindings: staging: iio: cdc: ad7746: add binding documentation for
> > AD7746
> > staging: iio: cdc: ad7746: use dt for capacitive channel setup.
>
> Looks good to me. Thanks!
>
> Will leave time for Rob or anyone else to take a look etc before applying.
>
> If I seem to have lost it then feel free to give me a poke in a few weeks
> (it's happened a few times in the past :(
>
> Thanks,
>
> Jonathan
> >
> > .../bindings/iio/cdc/adi,ad7746.yaml | 77 +++++++++++++++++++
> > drivers/staging/iio/cdc/ad7746.c | 54 ++++++++-----
> > drivers/staging/iio/cdc/ad7746.h | 28 -------
> > 3 files changed, 110 insertions(+), 49 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml
> > delete mode 100644 drivers/staging/iio/cdc/ad7746.h
> >
>

Hey Jonathan,

It has been a week or so without any more feedback, so I'm just a pinging here
to know if this can be applied.

Thanks,
Lucas