Re: [PATCH 6/7] gpio/rockchip: always enable clock for gpio controller

From: Linus Walleij
Date: Wed May 19 2021 - 19:18:39 EST


On Thu, May 13, 2021 at 10:49 PM Heiko Stuebner <heiko@xxxxxxxxx> wrote:
> Am Montag, 10. Mai 2021, 08:37:22 CEST schrieb Jianqun Xu:
> > Since gate and ungate pclk of gpio has very litte benifit for system
> > power consumption, just keep it always ungate.
> >
> > Signed-off-by: Jianqun Xu <jay.xu@xxxxxxxxxxxxxx>
>
> Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx>
>
> I do agree with the reasoning and as an added benefit, we
> also drop all the clk_enable calls that don't do proper error
> handling right now ;-)

Heiko what is your general stance on the rest of the patches?
I was thinking I should merge them soon if you're not
against.

Yours,
Linus Walleij