Re: [PATCH v1 4/7] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells

From: Chanwoo Choi
Date: Wed May 19 2021 - 22:33:21 EST


On 5/11/21 6:10 AM, Dmitry Osipenko wrote:
> The ACTMON watches activity of memory clients. Decisions about a minimum
> required frequency are made based on the info from ACTMON. We can use
> ACTMON as a thermal cooling device by limiting the required frequency.
> Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit.
>
> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
> ---
> .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> index 2a940d5d7ab4..0aa9459b7751 100644
> --- a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
> @@ -63,6 +63,9 @@ properties:
> Should contain freqs and voltages and opp-supported-hw property, which
> is a bitfield indicating SoC speedo ID mask.
>
> + "#cooling-cells":
> + const: 2
> +
> required:
> - compatible
> - reg
> @@ -74,6 +77,7 @@ required:
> - interconnects
> - interconnect-names
> - operating-points-v2
> + - "#cooling-cells"
>
> additionalProperties: false
>
> @@ -118,4 +122,5 @@ examples:
> operating-points-v2 = <&dvfs_opp_table>;
> interconnects = <&mc TEGRA30_MC_MPCORER &emc>;
> interconnect-names = "cpu-read";
> + #cooling-cells = <2>;
> };
>

Acked-by: Chanwoo Choi <cw00.choi@xxxxxxxxxxx>

--
Best Regards,
Chanwoo Choi
Samsung Electronics